changes made in response to Richard's first set of comments #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusthoff
reviewed
Nov 24, 2024
| Ada, just as the use of the *public*, *private*, and *protected* parts of | ||
| classes is fundamental to creating abstractions in class-oriented | ||
| languages. Not every type can be private, as illustrated by the client | ||
| expectation for array indexing in Ada prior to Ada 2012. Not every type |
There was a problem hiding this comment.
Adding "prior to Ada 2012" here makes the uninformed reader wonder why is it now different in Ada 2012... Maybe we should come up with better examples of the necessity of non-private types.
gusthoff
reviewed
Nov 24, 2024
Comment on lines
+88
to
+90
| Now, here's the rub. | ||
|
|
||
| Constructor functions require that same compile-time visibility so the |
There was a problem hiding this comment.
Suggested change
| Now, here's the rub. | |
| Constructor functions require that same compile-time visibility so the | |
| Now, here's the problem: | |
| constructor functions require that same compile-time visibility so the |
Improving comparison with the original version.
Improving comparison with the original version.
gusthoff
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.