prefer if expressions #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjljvandelaar
commented
Dec 22, 2022
| end Optional_Index_Of; | ||
|
|
||
| function Others_Allowed_For | ||
| (Attribute : Attribute_Node_Id) return Boolean | ||
| is | ||
| begin | ||
| if Attribute = Empty_Attribute then | ||
| return False; |
There was a problem hiding this comment.
Example where if expression is even simplified away!
pjljvandelaar
commented
Dec 22, 2022
|
|
||
| else | ||
| if Match (S_Name, I_Regexp) then |
There was a problem hiding this comment.
Another example where if expression is simplified even further
pjljvandelaar
commented
Dec 22, 2022
| @@ -2341,11 +2328,7 @@ package body Scanner is | |||
|
|
|||
| begin | |||
| if Chr = CR then | |||
| if Source (P + 1) = LF then | |||
There was a problem hiding this comment.
Example where the condition is really limited to what it effects: only 2 or 1!
|
After this pull request, you might want to change some functions into expression functions to make the code even more readable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gprbuild developers,
Since Ada2012 the if expression is supported.
Using the if expression in many cases improves the readability of the code.
Greetings,
Pierre
P.S. When you see no if expression in the change, the code is simplified even further to improve readability.
Problem detected and solved by Rejuvenation-Ada crate
