Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use distro over ld #654

Merged
merged 1 commit into from
Apr 12, 2024
Merged

use distro over ld #654

merged 1 commit into from
Apr 12, 2024

Conversation

atalii
Copy link
Contributor

@atalii atalii commented Nov 16, 2023

The ld package seems to have renamed itself to distro. I came about this while packaging for nixpkgs, and figured an upstream patch may be of some utility. Thanks so much!

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@grouigrokon
Copy link
Contributor

Hello,
this is surely a great idea.
We are working on it on our (AdaCore) side to make sure it integrates smoothly in our uses of the e3-core package.
I will keep you informed.

@grouigrokon grouigrokon self-requested a review January 8, 2024 15:33
grouigrokon
grouigrokon previously approved these changes Jan 8, 2024
src/e3/os/platform.py Outdated Show resolved Hide resolved
@atalii
Copy link
Contributor Author

atalii commented Apr 11, 2024

Hi, I updated this patch to work with the new pyproject.toml setup. I know it's been a while, but @grouigrokon, do you think you could still look into merging this? It would make packaging in nixpkgs a little bit easier. Thanks!

Copy link
Contributor

@grouigrokon grouigrokon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me !
I wanted to make it myself, but just missed the opportunity :)
Thanks a lot !

@grouigrokon grouigrokon merged commit 7f8d3a5 into AdaCore:master Apr 12, 2024
11 checks passed
@atalii
Copy link
Contributor Author

atalii commented Apr 12, 2024

Seems ok to me ! I wanted to make it myself, but just missed the opportunity :) Thanks a lot !

No worries, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants