Slsa provenance #645
Merged
Slsa provenance #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouigrokon
force-pushed
the
slsa-provenance
branch
4 times, most recently
from
a0efe5c to
10ffb30
Compare
grouigrokon
force-pushed
the
slsa-provenance
branch
from
10ffb30 to
18b843b
Compare
|
Comments from review have been taken into account. |
This provenance package is the implementation of the SLSA provenance specifications at https://slsa.dev/spec/v1.0/provenance For now, at least two enhancements are possible: - Some parameters are TypeURI or ResourceURI, but the specification says they are strings. Setting those attributes as `str` and having a check that they fit with TypeURI or ResourceURI classes could be better. Documentation fixes ------------------- Removed some warning about autoapi documentation, and some about possible classes mixes. Still the warning about PIPE import in TYPE_CHECKING could not be resolved. Review changes -------------- - Removed DigestSet and DigestAlgorithm enum. A digest set is considered a dictionary of str: str. The ResourceDescriptor's digest may be set, or new digest added by the add_digest() method. - The dir_hash() method has been moved to ResourceDescriptor ... maybe not the best place though. - Fixed a minor typo in the dsse package documentation - Added `as_dict()`, `as_json()`, `load_dict()` and `load_json()` for all the objects. - Added a provenance file example in the tests, and load it.
grouigrokon
force-pushed
the
slsa-provenance
branch
from
18b843b to
0133ca5
Compare
Nikokrock
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SLSA provenance package.
This provenance package is the implementation of the SLSA provenance
specifications at https://slsa.dev/spec/v1.0/provenance
For now, at least two enhancements are possible:
says they are strings. Setting those attributes as
strand havinga check that they fit with TypeURI or ResourceURI classes could be
better.
Documentation fixes
Removed some warning about autoapi documentation, and some about
possible classes mixes.
Still the warning about PIPE import in TYPE_CHECKING could not be resolved.
Review changes
a dictionary of str: str. The ResourceDescriptor's digest may be set,
or new digest added by the add_digest() method.
the best place though.
as_dict(),as_json(),load_dict()andload_json()for allthe objects.