Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifier error tracing #611

Conversation

JulienBortolussiAda
Copy link
Contributor

Enhance the errors raised by the qualifier manager to show the parent (above in the dependency tree) spec.

@JulienBortolussiAda
Copy link
Contributor Author

Solve #609

@JulienBortolussiAda JulienBortolussiAda force-pushed the qualifier_manager-improve_error_tracing branch 3 times, most recently from 11704af to 3375f39 Compare July 25, 2023 10:07
@grouigrokon
Copy link
Contributor

You should run pre-commit run --all-files before pushing ...

@JulienBortolussiAda JulienBortolussiAda force-pushed the qualifier_manager-improve_error_tracing branch from 3375f39 to f6efa25 Compare July 25, 2023 12:41
@@ -171,13 +172,20 @@ class AnodDummy(Anod):
with pytest.raises(AnodError) as err:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it should raise a QualifierError right ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this every where I found it

@JulienBortolussiAda JulienBortolussiAda self-assigned this Jul 26, 2023
@JulienBortolussiAda JulienBortolussiAda force-pushed the qualifier_manager-improve_error_tracing branch from f6efa25 to 1d8e2e4 Compare July 26, 2023 15:44
Enhance the errors raised by the qualifier manager to show the parent
(above in the dependency tree) spec.
@JulienBortolussiAda JulienBortolussiAda force-pushed the qualifier_manager-improve_error_tracing branch from 1d8e2e4 to 9482731 Compare July 27, 2023 13:36
Copy link
Contributor

@leocardao leocardao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants