Skip to content

Commit

Permalink
Fix e3-pypi-closure name comparison
Browse files Browse the repository at this point in the history
Before this patch, if you had a requirement like 'Django==2.2',
the version constraint would be ignored because the code was trying to
compare 'Django' == 'django'

Now we don't have to worry about character case in this comparison,
which corrects the problem.
  • Loading branch information
leocardao committed Jun 7, 2024
1 parent 5a47569 commit eb6bf82
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/e3/python/pypi.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def add_constraint(self, requirement: Requirement) -> None:
"""
logging.debug(f"Apply constraint: {str(requirement)}")
# Check if requirement applies to that package
if canonicalize_name(requirement.name) != self.name:
if canonicalize_name(requirement.name) != canonicalize_name(self.name):
return

# Check platforms
Expand Down

0 comments on commit eb6bf82

Please sign in to comment.