Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to extract_packets.py to extract only the layer payload #1304

Closed
wants to merge 1 commit into from

Conversation

mgrojo
Copy link
Contributor

@mgrojo mgrojo commented Oct 20, 2024

This allows, for example, to extract from a CoAP capture the payload of inet.UDP to obtain the CoAP messages.

Tested with:

wget  https://gitlab.com/wireshark/wireshark/-/wikis/uploads/__moin_import__/attachments/SampleCaptures/coap-cbor.pcap
extract_packets.py -p inet.UDP coap-cbor.pcap samples/
rflx validate -v samples/ specs/coap.rflx CoAP::CoAP_Message

This allows, for example, to extract from a CoAP
 capture the payload of inet.UDP to obtain the
 CoAP messages.

Tested with:
```
wget  https://gitlab.com/wireshark/wireshark/-/wikis/uploads/__moin_import__/attachments/SampleCaptures/coap-cbor.pcap
extract_packets.py --payload inet.UDP coap-cbor.pcap samples/
rflx validate -v samples/ specs/coap.rflx CoAP::CoAP_Message
```
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@treiher
Copy link
Collaborator

treiher commented Oct 23, 2024

Thanks for this improvement, @mgrojo! The code looks good to me. We just need a signed CLA from you to be able to merge it.

@mgrojo
Copy link
Contributor Author

mgrojo commented Oct 24, 2024

OK. The need to sign a CLA wasn't documented, but ok, the CLA Is now signed.

@treiher
Copy link
Collaborator

treiher commented Oct 28, 2024

Thanks again for your contribution! This change has been added to main in a603ffa.

@treiher treiher closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants