Improve the simplification of Neg further

Ref. eng/recordflux/RecordFlux#1797
AdaCore · Oct 28, 2024 · e2905c5 · e2905c5
1 parent 4e18a65
commit e2905c5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/rflx/expr.py b/rflx/expr.py
@@ -726,12 +726,7 @@ def substituted(
         return expr
 
     def simplified(self) -> Expr:
-        simple_expr = self.expr.simplified()
-        if isinstance(simple_expr, Neg):
-            return simple_expr.expr
-        if isinstance(simple_expr, Number):
-            return -simple_expr
-        return self.__class__(simple_expr, self.location)
+        return -self.expr.simplified()
 
 
 class MathAssExpr(AssExpr):

diff --git a/tests/unit/expr_test.py b/tests/unit/expr_test.py
@@ -702,7 +702,7 @@ def test_neg_substituted() -> None:
         # Argument simplifies to some other expression
         (
             Neg(Mul(Variable("X"), Add(Number(2), Number(3)))),
-            Neg(Mul(Variable("X"), Number(5))),
+            Mul(Variable("X"), Number(-5)),
         ),
         # Argument cannot be simplified
         (Neg(Variable("X")), Neg(Variable("X"))),