&& Brittany Jones Ampers

[brittanyrjones]

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?	Some code that we write is only applicable on certain actions, which means some of the code does not need to be loaded at the same time the page is loaded. For example, a click action.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?	My all trips button appears when the page loads, But when the button is clicked, it loads the list of trips. I had to add an on click event handler on the button so it loads the trips when clicked.
What kind of errors might the API give you? How did you choose to handle them?	Creating a reservation can return an error without the proper fields filled in on the form. I had some issues creating a trip, so far it is printing out an error in my console, and the user can see something went wrong on the browser error message
Do you have any recommendations on how we could improve this project for the next cohort?	It was kind of hard to work on a bunch of small projects at the same time, with them all being introduced around the same time too. It is good to practice working on many projects at the same time, but my git hygiene suffered and I did not commit as much as I should have.

[CheezItMan]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	As you noted, you should commit more
Comprehension questions	Check, asynchronous actually means that code may not be executed sequentially and that you cannot predetermine the order of events. Different functions seem to operate simultaneously.
Functionality
Click a button to list trips	Check, but you're using jQuery instead of axios?
Click a trip to see trip details	Check, but ditto on the above concern
Fill out a form to reserve a spot	It does work, but does not inform the user. Also it seems to change the currently selected trip somehow.
Errors are reported to the user	Only vague errors reported.
Styling	Minimal styling, you did import the Foundation CSS
Under the Hood
Trip data is retrieved using from the API	Check
JavaScript is well-organized and easy to read	Everything is crammed into document.ready. Not everything needs to be.
HTML is semantic	You have some unnecessary divs, but overall ok.
Overall	It's very odd that you elected to use jQuery for the API work. I'm curious about that decision. You have code to make the API calls, but styling is almost nonexistent and You have issues reporting success and errors to the user. Those would be things to work on. Hopefully React is going better for you.

[CheezItMan]

Your JavaScript should hide this form until there's a trip to submit details about.

[CheezItMan]

👍

[CheezItMan]

You've styled the single trip to show at the bottom rather than to the right.

[CheezItMan]

You should output the validation errors like we did in class.

[CheezItMan]

Why are you using jQuery to do post requests rather than using Axios like we did in class?

[CheezItMan]

This id #confirmation-msg does not exist in the HTML page.