Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leti - Ampers - Trek #37

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Leti - Ampers - Trek #37

wants to merge 12 commits into from

Conversation

LetiTran
Copy link

@LetiTran LetiTran commented May 29, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that several tasks can be running at the same time, without having to wait for one to finish in order to start another.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Fetching data with the API while scrolling down the page and displaying a 'status' message for the user.
What kind of errors might the API give you? How did you choose to handle them? The request for a reservation on the API requires a name and an email and it will return an error if not provided. I chose to display the reason of the error to the user in a modal window and give them the option to try again.
Do you have any recommendations on how we could improve this project for the next cohort? Make sure the requirements on the feedback page are aligned with the current expectations before/while presenting the project (e.g. Foundation)

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check, noted on Foundation
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check, although see my note, it's easy to miss
Styling Very nicely styled, I like the modal. I like how you incorporated Foundation into the project. I also like how it's responsive
Under the Hood
Trip data is retrieved using from the API Check
JavaScript is well-organized and easy to read Check
HTML is semantic Too many div elements everywhere, use semantic tags where possible
Overall Nice work, you hit all the learning goals and a few extras. Outstanding!

// STATUS MANAGEMENT:
const reportStatus = (message) => {
$('#status-message').addClass('callout primary');
$('#status-message').html(message);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, for me the browser jumps down below this element so I didn't see the error message until I browsed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants