Updated PR from master #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…views/drivers/show
…driver_status partial, updated driver#edit
…yed as a link if the driver has not been deleted
…passenger show view
CheezItMan
reviewed
Apr 9, 2018
There was a problem hiding this comment.
The feedback hasn't changed much from: #13 (comment)
However I've left some notes in the code here. You still, on MediaRanker, need to work on putting business logic in the model, rather than doing calculations in the controllers. Overall you did well however.
| resources :drivers | ||
|
|
||
|
|
||
| get 'user_interfaces', to: 'user_interfaces#index', as: 'user_interfaces' |
There was a problem hiding this comment.
You don't need this route here, as you're just using user_interfacesController as the root path.
| # Calculate driver total rating: | ||
| number_of_ratings = 0 | ||
| @rating = 0 | ||
| Trip.where(driver_id: @driver.id).each do |trip| |
There was a problem hiding this comment.
This should totally be in the Driver model.
| @passenger = Passenger.find(id) | ||
|
|
||
| @total_paid = 0 | ||
| @passenger.trips.each {|trip| @total_paid += trip.cost} |
| def update | ||
| @passenger = Passenger.find_by(id: params[:id]) | ||
| if [email protected]? | ||
| @passenger.update(passenger_params) ? (redirect_to passenger_path(@passenger.id)) : (render :edit) |
There was a problem hiding this comment.
You have a lot of good uses of ternary operators.
|
|
||
| <h2><%= page_title %></h2> | ||
| <% if @driver.errors.any? %> | ||
| <ul class="errors"> |
| <%= f.text_field :phone_num %> | ||
|
|
||
| <%= f.label :img, "Picture" %> | ||
| <%= f.select :img, [['Bear', "https://placebear.com/100/100"], ['Beyonce', "http://placebeyonce.com/100-100"]] %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rideshare-Rails
Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.
Comprehension Questions