Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

&&Jackie & Nicoleta #24

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

&&Jackie & Nicoleta #24

wants to merge 54 commits into from

Conversation

nbrandolini
Copy link

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way We decided that Trips belongs to Drivers and Passengers and that we only needed the passenger to have access to request a trip. NB
Describe the role of model validations in your application We are validating for the presence of name and VIN for the Driver and for name and phone for the Passenger and in the Trip for rating, passenger_id , and driver_id
How did your team break up the work to be done? We set-up our project together and then we branched and each worked separate on Driver and Passenger. The Trip part we did it as a team and it was awesome. Jackie is fantastic!
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? I feel like we met the requirements, however with more time we could have spend more time styling and maybe refactor our code a bit?
What was one thing that your team collectively gained more clarity on after completing this assignment? Routes for me (NB) and gain more knowledge of Rails
What is your Trello URL?
What is the Heroku URL of your deployed application? https://jn-rideshare.herokuapp.com/trips
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? NB: It was very easy to work with Jackie, she is very patient, and I feel like we were able to communicate very well.

nbrandolini and others added 30 commits April 2, 2018 16:44
… into view_passengers_trips

Want to see most updated master branch.
Update master branch with most recent updates
nbrandolini and others added 24 commits April 5, 2018 14:35
… their availability to false, true when completed
@Jackiesan
Copy link

Jackiesan commented Apr 7, 2018

Unable to add comments above.. adding more comments below

Question Answer
What was one thing that your team collectively gained more clarity on after completing this assignment? We gained more clarity on forms and validations. We also got a lot of practice with migration and routing. It was also fun deploying on Heroku!
What is your Trello URL? https://trello.com/b/l25hytYb/rideshare
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? It was a pleasure working with Nicoleta. We really took the time to plan and write pseudocode before implementing changes. We had very good communication and we kept giving each other updates about any changes made.

@tildeee
Copy link

tildeee commented Apr 10, 2018

Rideshare-Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing x
Answered comprehension questions x
Uses named routes (like _path) x
RESTful routes utilized x
Rideshare Rails Specific Content
Table relationships x
Validation rules for Models x
Business logic is in the models x
Database is seeded from the CSV files x
Trello board is created and utilized in project management x
Postgres database is used x
Heroku instance is online x
The app is styled to create an attractive user interface x
Overall

Good work with this project! It functions and behaves as expected.

Nice handling the custom messages for drivers with no trips!

Overall, great job! The code looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants