&& Brittany Jones Ampers

[brittanyrjones]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I had to resolve mostly typos. I also had to resolve some errors where I named text color, or text width, which does not exist.
Why is it important to consider and use semantic HTML?	Google and other search engines see the page without styles. The only way for search robots to understand which elements on the page are more important than others is through the markup. So search engine optimization is one good reason to use semantic markup.
How did you decide to structure your CSS?	I structured it by where it was functioning in the HTML.
What was the most challenging piece of this assignment?	The most challenging part was keeping the design fluent through each document. It was also challenging to format the resume, while keeping it easy to read and professional looking.
Describe one area that you gained more clarity on when completing this assignment	I gained clarity on using one single base code for designing the elements of multiple pages. I also gained clarity on using :hover, and other pseudos.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?	Not yet, but I am hoping to once I have finished all pages.
Overall

[CheezItMan]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Good number of commits, but some of the messages don't make sense. What does "All tests passed" mean in an HTML site?
Answered comprehension questions	Check, but I'm unclear what it means to keep the design fluent
Page fully loads	No, the css files aren't linked properly
No broken links (regular or images)	All your links are absolute links. You need to use relative links. See my in-code notes.
Includes at least 4 pages and styling	Only 3 pages and they're unfinished.
HTML
Uses the high-level tags for organization: header, footer, main	You are overusing div elements. Use main, header, footer and other elements.
Appropriately using semantic tags: section, article, etc.	Same as above.
All images include alternate text	Only one image, it does have an alt attribute
CSS
Using class and ID names in style declarations	Check, I would avoid using IDs in the style definitions, unless you really need it as they can't be reused and are hard to override.
Style declarations are DRY	Mostly yes.
Overall	You're obviously not finished, I'd like you to review either with me or with Charles relative vs absolute links. That's essential if you want to be able to make websites, and with Rails, you'll definitely need to be able to do this. It's hard to comment further as you're not finished.

[CheezItMan]

You're using absolute links which only work on your computer. You need to use links relative to the file you're linking from. In this case you should do:

  <li><a href="portfoliohome.html">Home</a></li>
  <li><a href="resume.html">Resume</a></li>

[CheezItMan]

spelling

[CheezItMan]

You should use semantic HTML tags whenever possible and avoid div elements.

[CheezItMan]

A note: It's traditional to name the homepage for an HTML site index.html and to put it in the root folder of the project. Try to follow convention, unless you have a reason not to.