Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brenda Rios - Personal Portfolio Site - Octos #23

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

brendarios
Copy link

@brendarios brendarios commented Mar 19, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, almost all of them were to remove the px from the height and width attribute I included in the images, since they are pixels I dont need to write again px
Why is it important to consider and use semantic HTML? this helped me to understand better html and the organization of all the elements.
How did you decide to structure your CSS? I made a general style sheet called style.css were I included the CSS of elements like navigation bar and footer since all the pages have them. Then I created a CSS file for each page to style them individually.
What was the most challenging piece of this assignment? At the beginning the structure of the HTML, then some challenges organizing the layout like making the footer stay at the bottom. This is the first time I create a webpage. All I know about HTML and CSS is what we learned this week, so no previous experience so I guess with more practice I will improve in semantic html and layout.
Describe one area that you gained more clarity on when completing this assignment Using flex box is more clear now for me, I used it to make the CSS of the navigation bar and footer and to organize pictures in some pages.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main mostly - see inline
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - good use of multiple files to keep things organized and DRY
Overall Great work overall! This site is attractive and easy to navigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants