Victoria Garcia - Ampers - Personal Portfolio

[Lasiorhine]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?

Why is it important to consider and use semantic HTML? |

Yes. I had done a whole bunch of multiple-class assignments wrong, and with one (an image resizing thing) when I fixed it, it broke a bunch of stuff downstream, so I had to remove the resizing mechanism entirely.

How did you decide to structure your CSS? |

I did it in header-nav-main-footer order, with stuff for each of the different "main" sections for the four pages grouped in what I hope is a fairly obvious way.

What was the most challenging piece of this assignment?

Getting my splash-page graphic to work. This is still not quite what I was picturing, but it's close enough for now.

Describe one area that you gained more clarity on when completing this assignment |

I got a much better grip on how to use flexbox and grid.

Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |
Overall |

[tildeee]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	x
Answered comprehension questions	The questions are in a weird format on the PR and I think the answer to the first question got swallowed up?
Page fully loads	x
No broken links (regular or images)	x
Includes at least 4 pages and styling	x
HTML
Uses the high-level tags for organization: header, footer, main	x
Appropriately using semantic tags: section, article, etc.	x
All images include alternate text	x
CSS
Using class and ID names in style declarations	x
Style declarations are DRY	x
Overall

Just a few notes about conventions--
You end up declaring CSS classes/ids in HTML with code like <section ID = "cabinet_or_lounge" class = "container">. Two small notes:

• It's convention to declare id's and classes without the space and all lower case
• it's CSS convention to make class names hyphenated instead of underscores (this is very not important in the grand scheme of things)
  therefore, the most conventional code would look like this: <section id="cabinet_or_lounge" class="container">

Otherwise, it looks good! Great job