Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariko - Ampers #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Mariko - Ampers #33

wants to merge 4 commits into from

Conversation

marikoja
Copy link

@marikoja marikoja commented May 18, 2018

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? The test structure was very similar to ruby, also defining arrays, and objects are very similar to ruby hashes. And if else statements too.
What was a challenge you faced in this assignment? In this project I struggle with understanding the scope of this, knowing which loop to use and the syntax in general with JavaScript.
Do you have any recommendations on how we could improve this project for the next cohort? I like the size of this project, at first it felt a little overwhelming but I was able to wrap my head around it by the end.

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements Not nearly enough commit
Git hygiene Not nearly enough commits, good commit mesages
Comprehension questions Check, I'm glad you found parallels, and glad that you overcame your struggle with the scope of the project.
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions These methods should be part of the Player class.
Overall Well done, you hit all the major learning goals, excellent work!

return wordScore
},

highestScoringWord(arrayOfWords) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two methods should be in the Scrabble.Player class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants