Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiera - jsscrabble - Octos #28

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

Krashaune
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? the one I used most heavily was conditionals they work exactly the same just different syntax. Another Ruby thing I tapped into was the concept of self methods for classes. I was able to use this to call other methods in the class.
What was a challenge you faced in this assignment? The biggest challenge I continue to have and I am not surprised that it came up in this project is working through complex functions such as highestscorefrom. I am sure it could use some refactoring but, I spent the most time on that function and debugging tools to understand what was happening in different parts of the function.
Do you have any recommendations on how we could improve this project for the next cohort? No I love that are first project was something we already solved in Ruby which made the logic and functions easier to write even without looking at the Ruby project. It allowed me to focus more on syntax.

@kariabancroft
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Yes
General
score calculates score, has appropriate params and return value Yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value Yes
Player object
Has name and plays properties Yes
Has play, totalScore, hasWon functions Yes
Has highestScoringWord and highestWordScore functions Yes - nice job using the functions you've previously created
Overall You did a nice job hitting the major learning goals and exploring the JS syntax in this assignment. You did a nice job with using semi-colons, there were only a few places that I noticed where they are missing.

if (word_score[word] > highest_score) {
highest_score = word_score[word];
winWord = word;
} if (word_score[word] === highest_score && winWord.length === 7) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These conditionals are structured like you want them to be nested in the else ifs, but they're all independent conditions. Recommend switching to else if

} else {
let word_score = {};
arrayOfWords.forEach(function(word) {
word_score[word] = Scrabble.score(word);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you're storing the scores in an object so you don't need to recalculate the scores each time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants