Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

&& Brittany Jones Ampers #45

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

brittanyrjones
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. The user beings to fill out the form, and the onFieldChange function sets the state of the function based on the changes made to corresponding fields. OnFormSubmit then does the submission when the card is added. It uses the callback function to submit the new card's info to the API. ComponentDidMount will run retrieving the updated list of cards from the API, and a new card is created in Board's render function. The page will re-render with the new card.
How did you learn how to use the API? I spent a lot of time on Postman, API docs, google, and had help from tutor.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? I used ComponentDidMount() because it runs after the initial render and retrieves the list of cards, and this is something the user should be able to see when the page is initially rendered.
Explain the purpose of a Snapshot test. It compares the current DOM with a previously-recorded snapshot taken of the dom, by running the tests.
What purpose does Enzyme serve in testing a React app? It is a testing library which sets up mock environments for testing the app, using simulate, shallow, etc.

@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check
General
Card Component renders the data provided as props Check
Board Component takes a URL and renders the list of Cards and passes in callback functions Check
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component Check
API
GET request made in componentDidMount Check
DELETE request made in callback function Check
POST request made in callback function passed to NewCardForm component. Check
Snapshot testing Check
Styling Looks ok, made some use of Dee's pre-built styles.
Overall You hit all the learning goals for the project Nice work!

Delete Card
</section>
<section className="card__content">
<span className="card__content-text">{this.props.text}</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in propTypes?

this.setState({
message,
const cards = this.state.cards;
const newCard = {'card': card};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never using newCard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants