Ampers: Fur-eign Keys #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… weird. Seems ok now, though.
… and an additional instance of OrderItem is not created.
… method for the cart controller. Nothing is completed or functional yet w/re this.
…e updated and working. Methods within the cart controller for add_product, access_cart, and the private create_cart are also working.
…to make new instances for anyone other than the logged in user.
…ctionality now attached.
…nued_products_orders_orderitem_reviews_controller_testing
…nued_products_orders_orderitem_reviews_controller_testing
…s_controller_testing
bEtsyWhat We're Looking For
Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it. |
CheezItMan
reviewed
May 4, 2018
| @product_2 = products(:product_2) | ||
| @product_2.user_id.must_equal @user_2.id | ||
|
|
||
| modified_2 = Product.find_by(user_id: @user_2.id) |
There was a problem hiding this comment.
You should be finding the product by the product ID not user.id. This test is failing due to that!
|
|
||
| get '/auth/:provider/callback', as: 'auth_callback', to: 'sessions#create' | ||
|
|
||
| get '/auth/github', as: 'github_login' |
There was a problem hiding this comment.
This route shouldn't be here. Omniauth is adding this route to redirec the user to github.
| <%= f.select :id, Category.all.map { |category| [category.name, category.id] }, :prompt => 'Select a category' %> | ||
| </div> | ||
| <div class="filter-button"> | ||
| <%= f.submit "Sumbit", class: "button" %> |
There was a problem hiding this comment.
submit? This button won't show as you aren't making a submit button.
|
|
||
| def update_cart_info | ||
| @cart = Order.find_by(id: session[:cart_order_id]) | ||
| if @cart && @cart.id == session[:cart_order_id] |
There was a problem hiding this comment.
Maybe strong params would be useful here.
| before_action :require_login | ||
| skip_before_action :require_login, only: [:create] | ||
|
|
||
| def new |
There was a problem hiding this comment.
What purpose is this route/action serving?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bEtsy
Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.
Comprehension Questions