Ampers: Nora Peters #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oning of this app but casually left out by Rails...cool.
…adds get_recipe method for search#show
API MuncherWhat We're Looking For
|
CheezItMan
reviewed
May 9, 2018
|
|
||
| require "minitest/rails" | ||
| require "minitest/reporters" # for Colorized output | ||
|
|
There was a problem hiding this comment.
You need to have this in here:
# MonkeyPatch for This version of Rails :(
if ActionPack::VERSION::STRING >= "5.2.0"
Minitest::Rails::TestUnit = Rails::TestUnit
end| @@ -0,0 +1,17 @@ | |||
| <h3>Results for: "<%= @search_terms %>"</h3> | |||
| <section> | |||
| <div> | |||
There was a problem hiding this comment.
Not sure this div is really needed here.
| @recipes_list = [] | ||
| end | ||
|
|
||
| encoded_search_terms = URI.encode(search_terms) |
There was a problem hiding this comment.
There's no checking to ensure that search_terms is a string and it's non-empty.
|
|
||
| def index | ||
| @search_terms = params[:search_terms] | ||
| @recipes = RecipeApiWrapper.find_recipes(@search_terms).paginate(page: params[:page], per_page: 10) |
There was a problem hiding this comment.
You need some sort of check to ensure that @search_terms is not null. The same applies to params[:page]
| it "can get recipes index" do | ||
|
|
||
| VCR.use_cassette("recipes") do | ||
| get recipes_path |
There was a problem hiding this comment.
This test is failing because you're not setting a param here for this path.
get recipes_path, params: {search_terms: query}| get recipes_path | ||
|
|
||
| query = "chicken" | ||
| RecipeApiWrapper.find_recipes(query) |
There was a problem hiding this comment.
Why are you making API Wrapper calls directly here? This should be only making controller calls.
| get recipe_path("7bf4a371c6884d809682a72808da7dc2") | ||
|
|
||
| recipe_id = "7bf4a371c6884d809682a72808da7dc2" | ||
| RecipeApiWrapper.get_recipe(recipe_id) |
There was a problem hiding this comment.
Again, this is a controller test, not a test of the wrapper.
| VCR.use_cassette("get_recipe") do | ||
| RecipeApiWrapper.find_recipes("chicken") | ||
| recipe_id = "7bf4a371c6884d809682a72808da7dc2" | ||
| @recipe = RecipeApiWrapper.find_recipe(recipe_id) |
There was a problem hiding this comment.
Should be:
@recipe = RecipeApiWrapper.get_recipe(recipe_id)|
|
||
| it "Returns empty array if there are no query matches" do | ||
| VCR.use_cassette("recipes2") do | ||
| query = 2429384725434.229384687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions
NOTE: I keep getting the error: "uninitialized constant Minitest::Rails::TestUnit (NameError)". I tried all of the things mentioned in Slack and tried troubleshooting a bunch on my own, but I still can't get my tests to run.