Scrabble

LetiTran · 2018-02-23T23:33:25Z

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the advantages of using git when collaboratively working on one code base?	One advantage is that both of us can contribute to the same project and both of us can have access to the most recent updates. We can also view a log of all the changes made by the other person. Git also helps manage conflicts.
Why do you think we chose to make the `score` method in the `Scoring` class a class method instead of an instance method?	We made score a class method so that we can directly access the method from other classes within the same Module Scrabble.
Describe an example of a test you wrote for a nominal case.	We created a test to return the sum of scores of played words. We made our instance of a player play two words and in the assert statement we indicated that the score must equal the number we manually calculated.
Describe an example of a test you wrote for an edge case.	We wrote a test within scoring_spec in which if max score is tied and none of the words have a length of 7 the selected winning word would be the one with less characters.
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	We used select, max_by, and min_by in scoring.rb in the self.highest_score_from method. They were helpful to use in this method because it made our code more concise without having to use .each method.
What was one method you and your pair used to debug code?	We inserted puts statements in places in which we thought the code was having issues. We also followed the stack trace to help us figure out where the errors were coming from.
Is there a specific piece of code you'd like feedback on?	Did we efficiently use max_by and min_by in scoring.rb in the self.highest_score_from method or are there other enumerable methods that are more appropriate for what we wanted to do.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	For us, the ping pong method allowed us to equally divide time spent driving and navigating. We consistently explained our code to each other which helped us understand what each part does. There was one part in wave 3 that we spent too much time trying to debug and we both think that if we were to do this again, we would have asked for help earlier.

… test OK

…s played'

… played words.

…ssed the initialize test for it.

…fault set

…d fixed all tests related to it.

…_from(scoring.rb) method to score every word from the given array and find the 'winner word'.

… assertion to draw_tiles player_spec.

…tead of if statments.

…te points

… a unecessary require command at the top of file.

CheezItMan · 2018-02-26T08:21:26Z

Scrabble

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Check
Both Teammates contributed to the codebase	Check
Regular Commits with meaningful commit messages	Good number of commits and good messages
Scoring class
`score` method	Check
Uses appropriate data structure to store the letter score	Your way works, but there is a more compact way.
Appropriately handles edge cases	Check
`highest_score_from` method	Check
Appropriately handles edge cases	Check
Test implementations for `highest_score_from`	Yes, but see my note.
Player class
Uses an array to keep track of words played	Check, but play isn't working properly
Uses existing code to create `highest_scoring_word` and `highest_word_score`	Check
Returns `true` or `false` from `won?` method	Check
Tests edge cases on the `play(word)`	NOPE, see my in-code notes on your tests. You need to be much more through.
TileBag class
Uses a data structure to keep the set of default tiles in the bag	See my comment on the data structure
`draw_tiles` method uses the parameter to draw a set of random tiles	Check
`tiles_remaining` method returns a count	Check
Tests `draw_tiles` edge cases	You're missing the case where I try to draw 100 tiles.
Summary	Not bad you hit the learning goals. You need to be a bit more through in your edge cases and see my note about the structure you use in `TileBag`. However over all, nice work!

CheezItMan · 2018-02-26T08:02:51Z

lib/scoring.rb

+      # Set the points for that word to initialize at zero and calculate the points of each word, adding them to the points variable:
+      points = 0
+
+      letters_array.each do |letter|


This works, but is there a more compact way to do this, maybe with a hash?

CheezItMan · 2018-02-26T08:03:34Z

lib/scoring.rb

+      scoring_table = {}
+
+      # Set the scores of each word:
+      array_of_words.each {|word| scoring_table["#{word}"] = score(word)}


You don't need the interpolation here:

array_of_words.each {|word| scoring_table[word] = score(word)}

will work

CheezItMan · 2018-02-26T08:09:33Z

specs/scoring_spec.rb

    end

    it 'returns the highest word if there are two words' do
+      winning_words = Scrabble::Scoring.highest_score_from(["dog", "academy"])


Since order can potentially be important in the highest_score_from method repeating these tests by varying the order is useful.

Something like:

winning_words = Scrabble::Scoring.highest_score_from(["academy", "dog"]) winning_words.must_equal "academy"

CheezItMan · 2018-02-26T08:14:03Z

lib/player.rb

+# _________________PLAY METHOD____________________
+# Accepts a word as an argument and add it to the plays array.
+
+    def play(word)


Read the description again. This method is required to return false if they have already won prior to playing the word.

CheezItMan · 2018-02-26T08:14:41Z

lib/player.rb

+# Returns true if the toal score is more than 100, otherwise returns false.
+
+    def won?
+      total_score > 100 ? true : false


Good ternary

CheezItMan · 2018-02-26T08:15:47Z

specs/player_spec.rb

+      end
+    end
+
+    describe "#play(word)" do


What about:

Playing more than 1 word.

Playing an invalid word

Playing words after the player has already won!

CheezItMan · 2018-02-26T08:17:06Z

specs/player_spec.rb

+
+    end
+
+    it "Returns false if player has over 100 points" do


won? should return true if the player has >= 100 points. It's play that should return false

CheezItMan · 2018-02-26T08:18:33Z

lib/tile_bag.rb

+    attr_reader :bag
+
+    def initialize
+      @bag = {


There's a number of problems with this data structure. Most pressing is that it gives each letter an equal chance of being drawn. This is despite the fact that there are a lot more "E" tiles than "Z".

CheezItMan · 2018-02-26T08:18:57Z

lib/tile_bag.rb

+        new_letter = @bag.keys.sample
+        tiles_drawn << new_letter
+        @bag[new_letter] -= 1
+        @bag.delete_if { |letter, quantity| quantity == 0 }


Good that you're keeping the number of tiles from going negative.

CheezItMan · 2018-02-26T08:20:27Z

specs/tile_bag_spec.rb

+    end
+
+    describe '#tiles_remaining' do
+      it "returns number of tiles remaining in bag" do


You should also test to see what happens when I try to draw more tiles than are in the bag!

… comments from CheezItMan

LetiTran and others added 30 commits February 20, 2018 14:27

Added scoring method and fixed typo on the 'game' files - First score…

27059d0

… test OK

adds 50 pts to 7 letter word, returns nil for bad characters

ad5a0be

..

24022ff

returns nil for words > 7 letters

71bdb93

returns nil for empty words

1b70781

added code for 'returns nil if no words were passed' - OK

f89b00a

returns the only word in a length-1 array

e112d21

returns the highest word if there are two words - OK

78c157b

if tied, prefer 7 letter word

68481b7

if tied and no word has 7 letters, prefers the word with fewer letters

27b4827

returns the first word of a tie with same letter count

5d1ddef

..

f7dab82

Merge branch 'master' of https://github.com/LeticiaTran/Scrabble

5d4ef25

Initializes Player class and passes initialize test

f3b149f

Merge branch 'master' of https://github.com/LeticiaTran/Scrabble

0f2a8d1

'Added a method 'plays' and passed the test 'Returns an array of word…

fa5f61a

…s played'

Adds input word to @plays array.

0a34fec

added total_score method and passed test Returns the sum of scores of…

8263c3f

… played words.

won? returns true if player has over 100 pts

6a082a8

mmm needed this commit/dont understand why

27db390

added method highest_scoring_word and passed test.

ecc16a8

fixed indentention

bf0bc47

returns score of highest scoring word

4abaeba

Created TileBag class and files, initialized the TileBag class and pa…

b143409

…ssed the initialize test for it.

draws tiles from the tile bag

390cabe

removed wrong puts that was used for testing

e248d2c

Merge branch 'master' of https://github.com/LeticiaTran/Scrabble

25389fc

Fixed a typo on tile_bag.rb and passed test Removes tiles from the de…

e745716

…fault set

Draw_tiles(tile_bag) not passing test

e320ff2

Draws tiles with max of 7

c4c3900

LetiTran and others added 17 commits February 22, 2018 18:34

just running tests....

cc8d12e

just running tests....

0c54c22

fills tile array until it reaches 7

4eb126f

Merge branch 'master' of https://github.com/LeticiaTran/Scrabble

7280a67

fills tile array until it reaches 7

0fe3c6c

git error...

64fec21

git error...

495dbc0

Added descriptive comments on class files.

4e25418

changed how TileBag is initialized (not taking any arguments now), an…

cd4c9f4

…d fixed all tests related to it.

Changed the highest_scoring_word(player.rb) to call the highest_score…

3965a05

…_from(scoring.rb) method to score every word from the given array and find the 'winner word'.

Deleted unecessary testing comments.

c21f74d

Refactor some iterations/conditional blocks into one line.

be94de4

Removed unnecessary scoring table hash variable from player.rb, added…

3ab27bf

… assertion to draw_tiles player_spec.

Changed method score in score.rb to calculate points using 'case' ins…

eac411c

…tead of if statments.

Merge branch 'master' of https://github.com/LeticiaTran/Scrabble

2678435

Merge after changing score method to use case instead of if to evalua…

deeb039

…te points

Changed how the highest_score_from is called on player.rb and deleted…

897a2c8

… a unecessary require command at the top of file.

CheezItMan reviewed Feb 26, 2018

View reviewed changes

LetiTran and others added 2 commits February 26, 2018 15:04

Refactor the project to atend to the necessary changes on the first 4…

0dfb93e

… comments from CheezItMan

Added edge cases to scoring_spec and tile_bag

2405cff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scrabble - Jackie & Leti (Ampers) #8

Scrabble - Jackie & Leti (Ampers) #8

LetiTran commented Feb 23, 2018 •

edited

Loading

CheezItMan commented Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

CheezItMan Feb 26, 2018

Scrabble - Jackie & Leti (Ampers) #8

Are you sure you want to change the base?

Scrabble - Jackie & Leti (Ampers) #8

Conversation

LetiTran commented Feb 23, 2018 • edited Loading

Scrabble

Comprehension Questions

CheezItMan commented Feb 26, 2018

Scrabble

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LetiTran commented Feb 23, 2018 •

edited

Loading