Cara & Emilce -- Scrabble -- Octos #15

emilcecarlisa · 2018-02-24T01:57:27Z

Scrabble

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the advantages of using git when collaboratively working on one code base?	Ability to merge and reconcile changes. Working remotely is made easy.
Why do you think we chose to make the `score` method in the `Scoring` class a class method instead of an instance method?	So that it can be updated by multiple instances
Describe an example of a test you wrote for a nominal case.	Tested the score of word.
Describe an example of a test you wrote for an edge case.	Tested if we received nil.
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	We used max and each with object method. It was helpful being concise and implicitly returning objects.
What was one method you and your pair used to debug code?	We used puts statements and pry ocassionally.
Is there a specific piece of code you'd like feedback on?	The draw tiles method in the tiles file.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We discussed communication styles and working on specific tasks.

…ebag.

CheezItMan · 2018-02-28T00:43:16Z

Scrabble

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Check
Both Teammates contributed to the codebase	Both members committed!
Regular Commits with meaningful commit messages	Good number of commit, You should focus less on the waves and numbered tests passed and more on the functionality you added in your commit messages.
Scoring class
`score` method	Check
Uses appropriate data structure to store the letter score	Check
Appropriately handles edge cases	Check
`highest_score_from` method	Check
Appropriately handles edge cases	Check
Test implementations for `highest_score_from`	Check
Player class
Uses an array to keep track of words played	Check
Uses existing code to create `highest_scoring_word` and `highest_word_score`	Check, but I left one note.
Returns `true` or `false` from `won?` method	Check
Tests edge cases on the `play(word)`	Yes, except for the case where I user keeps playing after they've won (what happens to the list of words played?)
TileBag class
Uses a data structure to keep the set of default tiles in the bag	Neat use of Enumerables to turn the hash into an array.
`draw_tiles` method uses the parameter to draw a set of random tiles	Check
`tiles_remaining` method returns a count	Check
Tests `draw_tiles` edge cases	MISSING Only one test for `TileBag`
Summary	Overall nice work, it looks like you ran out of time for TileBag testing, but overall very well done.

CheezItMan · 2018-02-28T00:18:32Z

lib/tilebag.rb

+      @tile_bag = BAG.each_with_object([]) { |(letter, value),tile_bag|
+      #iterate through the letters val times and shovel the
+      #letter to the individual letter tilebag
+        value.times { (tile_bag << letter.to_s)}} #


small indentation error. The above loops also look awkward. They are however an awesome way to turn the hash above into an array.

CheezItMan · 2018-02-28T00:19:15Z

lib/scoring.rb

  class Scoring
+    SCORING_RUBRIK =  {


Good use of a constant, and a good choice of data structure!

CheezItMan · 2018-02-28T00:20:22Z

lib/scoring.rb

+
+          elsif score == highest_score
+            # highest_word =
+            self.break_tie(highest_word, word)


Nice, a helper method!

CheezItMan · 2018-02-28T00:20:51Z

lib/scoring.rb

+    end
+
+    def self.break_tie(incumbent, challenger)
+


Nicely done here

CheezItMan · 2018-02-28T00:23:23Z

specs/scoring_spec.rb

    end

    it 'returns the highest word if there are two words' do
+      words = []
+      words.push("zebra", "otter")


I suggest also varying the order of the words since that makes a difference in a tie.

CheezItMan · 2018-02-28T00:26:43Z

lib/player.rb

+      # return @words_played
+    end
+
+    def play(word)


Problem here, even if I've won it pushes the new word into @words_played

CheezItMan · 2018-02-28T00:27:07Z

lib/player.rb

+    end
+
+    def total_score()
+      word_scores = @words_played.map do |word|


Good practice with .map and .inject

CheezItMan · 2018-02-28T00:27:39Z

lib/player.rb

+    end
+
+    def highest_word_score
+      highest_word = Scrabble::Scoring.highest_score_from(@words_played)


Couldn't you just use the highest_scoring_word here?

CheezItMan · 2018-02-28T00:29:01Z

specs/player_spec.rb

+
+  end
+
+  it "returns score of a play/word " do


What about a test for what happens if you keep playing after you won?

CheezItMan · 2018-02-28T00:37:11Z

lib/tilebag.rb

+        value.times { (tile_bag << letter.to_s)}} #
+      end
+
+      puts "#{@tile_bag}"


puts is unneeded here:

MississippiBrenn and others added 25 commits February 20, 2018 14:42

Passes first test

e2c52df

Added all letters and corresponding scores

224cb5d

2nd test passes

7587430

Uncommented test

8d37ff8

Sorry, small & irrelevant changes

4fe7c59

Merge branch 'master' of https://github.com/emilcecarlisa/Scrabble

a38c5e5

Passing the bad characters test

4f4eada

Started writing our own tests.

3548f89

Merging changes

7d32569

MERGING

85f75ed

Resolved MERGING

3a5b7c6

Passed all tests. Wave 1 complete

0892d57

Created player file and class

9ae753e

Added player_spec file

62cb538

Verifying files available

d47ddf1

Wave 2 first test passing

985493a

End of day Wed

7a621df

Added method to sum the word scores

f75b789

Added sum test.

5c19817

Added won method

caace60

Added the highest scoring word method and test

b113b7f

All tests are passing at once Wave 2

c732d94

Added the Tilebag initialize

b78233e

Wave 3, with one tess

b889754

Added functionality to draw random tiles and delete them from the til…

a4004b9

…ebag.

emilcecarlisa changed the title ~~Scrabble.rb~~ Cara & Emilce -- Scrabble -- Octos Feb 24, 2018

MississippiBrenn and others added 4 commits February 26, 2018 17:51

Working on file to pass

f86752a

All wave 1 tests are passing

56bc249

Updated scoring tests and method

8675e20

err

d9c0355

emilcecarlisa added 2 commits February 27, 2018 10:05

Adjusting player_spec tests(returns words played)

bfd2068

highest word/highest score tests running

7e69944

CheezItMan reviewed Feb 28, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cara & Emilce -- Scrabble -- Octos #15

Cara & Emilce -- Scrabble -- Octos #15

emilcecarlisa commented Feb 24, 2018

CheezItMan commented Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

CheezItMan Feb 28, 2018

Cara & Emilce -- Scrabble -- Octos #15

Are you sure you want to change the base?

Cara & Emilce -- Scrabble -- Octos #15

Conversation

emilcecarlisa commented Feb 24, 2018

Scrabble

Comprehension Questions

CheezItMan commented Feb 28, 2018

Scrabble

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment