Media Ranker Revisited - Angela - Octos #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaRanker RevistedWhat We're Looking For
|
droberts-sea
reviewed
May 5, 2018
| def build_from_github(auth_hash) | ||
| return User.new( | ||
| name: auth_hash['info']['name'], | ||
| email: auth_hash['info']['email'], |
There was a problem hiding this comment.
This should be a self method! In your controller you call User.build_from_github, which means logging in as a new user doesn't work.
I'm guessing you made the change after logging in for the first time, so you never hit it in a real workflow. That's why thorough testing is important, it's not always plausible to manually test things.
| # provider: auth_hash['provider']) | ||
| user = User.build_from_github(auth_hash) | ||
| if @user.save | ||
| session[:user_id] = @user.id |
| # it 'creates a DB entry for a new user' do | ||
| # old_user_count = User.count | ||
| # | ||
| # user = User.new( |
There was a problem hiding this comment.
Here is the test that would have caught those two bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.