Pipes-Mariana-api-muncher

[lmarianarp19]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I used the information provided in the website and I used postman, I never get to see the response when I looked for just one recipe, which make everything difficult.
Describe your API Wrapper. How did you decide on the methods you created?	I created one method to get the response when I look for one recipe and another one for getting just one recipe. Then I created two private methods, one than create a new instance of recipe and the other one that returns the status.
Describe an edge case or failure case test you wrote for your API Wrapper.	I tried to test when the user enter a word that doesn't have any matches.
Explain how VCR aids in testing an API.	It helps me to make possible to reuse API calls when making testing.
What is the Heroku URL of your deployed application?	https://a-cocinar.herokuapp.com/

[PilgrimMemoirs]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Mostly Good - Expand on some answers. For example. with the VCR question, why are the benefits of having that functionality? What is the purpose?
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML	Needs Improvement - Be Mindful of Indentation. And opening/closing tags, recipe's show.html.erb has a random at the end with nothing after it. There should only be one body tag (the one defined in application.html.erb). More semantic sectioning elements, like header should be used.
Errors are reported to the user	Well Done - do you need the conditional with @count in recipes index.html.erb? What is already doing that work?
API Wrapper to handle the API requests	Mostly Good - does the method find_recipes need to return the count with the collection of recipes? Since the collection is in an array, and a recipe object will be made for each recipe returned from the API, you can use the .length method on the array.
Controller testing	Well Done
Lib testing	Well Done
Search Functionality	Well Done
List Functionality	Well Done
Show individual item functionality (link to original recipe opens in new tab)	Well Done
Styling
Foundation Styling for responsive layout	Mostly Good - footer remains in middle of page when given smaller width. Text should have a responsive measurement to scale smaller with smaller width.
List View shows 10 items at a time/pagination	Well done
The app is styled to create an attractive user interface	Mostly Good - footer should stay at bottom of page.
API Features
The App attributes Edaman	Mostly Good - should link to edamame site
The VCR casettes do not contain the API key	Well Done
External Resources
Link to deployed app on Heroku	Well Done
Overall
Areas for Improvement	Tidy HTML code and use semantic sectioning tags.