Nkiru-Pipes-BackTrek

[nkiruka]

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What role does the Model play in Backbone?	* Please note, branch "working copy" has the most up to date code. I cannot merge into master and did not want to switch to working copy to default mode, until I resolve conflicts/check with instructor. Model includes the application data and business logic (similar to Rails models.)
How did the presence of Models and Collections change the way you thought about your app?	For this project model:Trip and Collection:TripList, backbone collection is an ordered set of models (ref. cdnjs.com)
How do Backbone Events compare to DOM events?	Backbone events mixed in to an object, give object ability to bind and trigger custom named events; DOM events manage how elements react to events.
How did you approach filtering? What was your data flow for this feature?	Did not get to this yet.
What do you think of Backbone in comparison to raw JavaScript & jQuery?	Backbone helps manage data and application logic and provides structure. Maintaining large & complex programs with js and jquery becomes tedious due to nested functions etc.
Do you have any recommendations on how we could improve this project for the next cohort?

[CheezItMan]

BackTREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages
Comprehension questions	Check, I'll do my responses on your workingcopy branch, but I can't do my in-code comments. You were asked how models and collections changed how you thought about the project. Also compare backbone event to DOM events, not a definition.
Organization
Models and collections are defined in separate files	Check
Code that relies on the DOM is located in or called by $(document).ready	Check
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)	Check
Functionality
Display list of trips	Check
Display trip details	Check
Register for a trip	Check, but no success or error messages displayed to the user, just console messages.
Add a trip	Check, but similar has not used client-side validations (although you have the validate function. You are also not checking for server-side errors.
Sort trips	Check, but no styling to indicate to the user the sorted column.
General
Snappy visual feedback for user actions	The styling is simple, and you're missing much feedback to the user about what's happened and validation errors.
API error handling	MISSING
Client-side validation	Really good that you're checking for the @ in the email for Reservation. I would also check for positive or 0 values in weeks and cost for Trip. You are also not checking to see if the trip isValid()
Overall	You hit most of the learning goals, you put in validate to Reservation and Trip. You just needed to use it in the app.js. Overall pretty good. Thanks for leaving me the note about the workingcopy branch.