Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipes - Tamira - BackTREK #23

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

pipes - Tamira - BackTREK #23

wants to merge 46 commits into from

Conversation

tvojnar
Copy link

@tvojnar tvojnar commented Dec 4, 2017

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? Models keep track of data and are the building blocks of collections.
How did the presence of Models and Collections change the way you thought about your app? Storing data in models and collections made things like sorting easier because you had local storage of the data.
How do Backbone Events compare to DOM events? Backbone events are triggered when something happens to a model or collection while DOM events are triggered when something happens to elements in the DOM.
How did you approach filtering? What was your data flow for this feature? I had a keyup event in the filter form trigger the key/value pairs in a hash that is a property of the TripList collection to be updated. Then render is triggered. In render my custom filter method is called on the collection and filtered by each kay/value pair in the property hash of the collection. Then the filtered array of trips is displayed on the page.
What do you think of Backbone in comparison to raw JavaScript & jQuery? Backbone makes everything easier because it adds more structure.
Do you have any recommendations on how we could improve this project for the next cohort? It felt like a really big project to have the week before interviews. The last could weeks were pretty mellow by comparison, so at least letting us know that this will be a big project ahead of times would be helpful so we can schedule our interview prep accordingly.

…f it hasn't already made an api call for that trip
…thod to try to make an api call to reserve a trip. Not working yet
@CheezItMan
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Lots of commits and good commit messages, good
Comprehension questions Check, Model also handle communicating to the API. We'll take your comments about the week into consideration for C9
Organization
Models and collections are defined in separate files Check
Code that relies on the DOM is located in or called by $(document).ready Check
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM) Well done!
Functionality
Display list of trips Check
Display trip details Check, although I nearly missed it because the block shows up at the bottom of the list.
Register for a trip Check
Add a trip Check
Sort trips Check
General
Snappy visual feedback for user actions The user gets good feedback on their actions. Getting the details pane to show next to or above the list would be ideal.
API error handling Check
Client-side validation Check, nicely done, I left a few notes in your code.
Overall Well done, you hit all the learning goals and it look like you started filtering. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants