Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Merge Feature #34

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Create Merge Feature #34

wants to merge 38 commits into from

Conversation

jbuechs
Copy link

@jbuechs jbuechs commented Mar 31, 2016

Merge feature:

  • shows on edit article page for admin, but not other users
  • does not show on new article page for any users
  • merges content and comments from selected article into edited article
  • deletes merged article

Created Cucumber tests for BDD

@@ -113,6 +113,20 @@ def autosave
render :text => nil
end

def merge
@article = Article.find(params["id"])
merge_article = Article.find(params[:merge_with])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good if this logic was in an Article model method instead of directly in the controller

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it to the model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants