Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and Edit Category Bug Fix #21

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

annaleeherrera
Copy link

A blog administrator can now view, create, and edit a category. The bug was preventing a user to successfully access admin categories and to edit and create them. An ID was not being assigned to the category, preventing the new, create, and edit methods in the admin categories controller to run. RSPEC and Cucumber tests passing, some pending.

Challenges: Initially I overlooked that there were separate admin and user sections of the site. I kept getting errors for a missing template when I was editing methods in the admin categories controller, so I started to create new views outside of admin. After closely examining the tests, I realized my mistake and the bugs became easier to fix.

@@ -1,4 +1,7 @@
class CategoriesController < GroupingController
# index - inherited
# show - inherited
def new

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this since the bulk of the work is in the admin?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked my git status and didn't commit this deletion. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still in here - maybe missing another commit?

@kariabancroft
Copy link

You should not have the db/db_development and db/db_test files in your commits, please delete and add to your gitignore

And I am logged into the admin panel

Scenario: Create category
Given I am a user

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this step given the "as a user" step at the beginning?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was also deleted, just had to commit the change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants