Bug Fix and Feature Added #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidation app only validates upon create
| @@ -19,6 +19,8 @@ dbfile = File.expand_path("../config/database.yml", __FILE__) | |||
| # end | |||
| #end | |||
|
|
|||
| gem 'pry-nav', group: [:development, :test] | |||
There was a problem hiding this comment.
Is there an existing development, test group that this gem should be added to?
|
you successfully excluded the db/db_test file but unfortunately the db/db_development file is still in here |
| @@ -1,84 +0,0 @@ | |||
| class LangaugeFile | |||
There was a problem hiding this comment.
Did you intend to delete this file?
There was a problem hiding this comment.
no, I accidently added it to git ignore and ran git rm --cached on it. It's now back in the app and being tracked. I added db/db_development to gitignore and it's no longer being tracked by git. I think this resolves all the issues from this PR. Thanks for the help!!
…ntroller, remove test for article count as it is covered in model spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs and created associated tests: (1) problem clicking Categories link on dashboard, (2) flash errors not displaying upon create.
Added feature allowing admin users to merge articles. Created cucumber and rspec tests before developing feature. Feature appears to work, but there are currently 3 failing cucumber tests and 2 failing rspec tests.