Elseabay #23
Open
Elseabay #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rates = ups.merge(usps) | ||
| render :json => rates.as_json, :status => :ok | ||
| rescue | ||
| render :json => { error: :bad_data, message: "You must provide valid data for package size, package weight, origin location and destination location." }, status: :bad_request |
There was a problem hiding this comment.
It's not a bad idea to let users know what 'valid date' is by giving them examples in the message.
There was a problem hiding this comment.
Most Ruby style guides recommend a line length of 80 characters. You can wrap your code by using indentations to show the continuance of the previous line. Here is a StackOverflow example
|
@lgranger @emgord Great job on your very first API! insert virtual high fives heres The nit pickiness of my code review is a testament to the fact that there wasn't any major refactoring to be done or major holes in your code. 🌟 If you have any questions about any of my comments please don't hesitate to reach out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/b/uE3b61qg/c2c-shipping