Completed(ish) PR #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice into rtown/master
…vice into rtown/master
| @@ -54,9 +63,15 @@ GEM | |||
| execjs | |||
| coffee-script-source (1.10.0) | |||
| concurrent-ruby (1.0.0) | |||
| crack (0.4.3) | |||
There was a problem hiding this comment.
I want to share this unnecessary supplemental reading I did after seeing this gem name: What is crack?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello board: https://trello.com/b/3LFDwbpS/rtown-shipping-service-fun
We completed most of the base requirements, with some bugs. Have decent error handling, timeout handling, and rspec coverage. However, packages with same item multiple times from bEtsy aren't adding up properly, and we realized some of our error messages aren't transmitting exactly as expected. With more time, we would investigate what is happening with the error logic and make sure that every item being shipping is accounted for.