-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping-service Pull Request #21
base: alddfp/master
Are you sure you want to change the base?
Conversation
def self.usps | ||
ActiveShipping::USPS.new(login: '677JADED7283') | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good practice to start creating .env files to store login info and keys to make API calls. Even for fake ones! Make a habit out of it!
ship_array = shipment_array(ship_params) | ||
ups_rates = get_rates(ship_array, ups) | ||
usps_rates = get_rates(ship_array, usps) | ||
quote = assemble_quote(ups_rates, usps_rates) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like how you guys consolidated shipping estimates into a single method.
Please read ReadMe for notes!
Trello Board: https://trello.com/b/TXJ6uwTM/shippingservice
BetterWetsy: https://github.com/mangolatte/betsy/tree/alddfp/master
heroku: betterwetsy.herokuapp.com