Shipple - Shipping Service API #18
Conversation
| end | ||
|
|
||
| def set_origin | ||
| ActiveShipping::Location.new(country: 'US', state: params[:origin][:state], city: params[:origin][:city], zip: params[:origin][:zip]) |
There was a problem hiding this comment.
It's a matter of what style guide you're using, but when the line is this long, I like to break it up into newlines. E.g.:
ActiveShipping::Location.new(
country: 'US',
state: params[:origin][:state],
[...]
This makes it more readable, but also makes on-the-job code reviews easier. Then if someone modifies a small part of just one of the elements, it's clear on the code review what they modified, rather than the whole line being colored.
|
@annaleeherrera and @daphnegold, Good job on this! This was well-executed, especially as a first API! Most of my comments were just styling preferences, but feel free to make your own decisions on style. It'll vary from team to team. Let me know if you have any questions on any of this, or if there's something in particular you were hoping for feedback about. |
|
Thank you so much for the comments on @catchingash! Your style notes are extremely helpful. |
Shipping service API for BOTsy app. Generates shipping rates from UPS and USPS. Requirements met.
Link to updated BOTsy app with Shipple API.
https://github.com/daphnegold/betsy
Link to Shipple Trello Board:
https://trello.com/b/822g87Dz/botsy-shipping-service