Jnkd/master - finished project

[kdefliese]

Link to our Trello board: https://trello.com/b/yL9iJtWA/junked

We would have liked to finish some ideas we had like having each merchant ship from its own address and creating multiple boxes, but we finished the major requirements.

Betsy fork deployed here: http://betsy-fork.herokuapp.com/
Shipping service deployed here: http://junked.herokuapp.com/ (but there's nothing to see)

[blip-lorist]

• Good use of status codes - this ultimately helps devs understand why something hasn't worked or hasn't returned content.
• Have you explored the VCR gem for API testing? You might find it interested: https://github.com/vcr/vcr
  Something like VCR can help because it creates "recordings" of an API's response so that you don't have to keep hitting the ActiveShipping API every time you run rspec. It just keeps a recording of the API response, which also allows you to test while offline / when the API is down.

[blip-lorist]

It would have been interesting to see what this would yield if ActiveShipping was unable to provide any options and how that would get communicated to the user (like if a package was millions of lbs).

[blip-lorist]

Great work overall - you hit all criteria defined by the technical requirements. I checked your Betsy fork, and it looks like you took care of timeouts with Net::ReadTimeout.