JLN js-tic-tac-toe #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.incrementScore(4, player); | ||
| } else if (track_space.substring(2,4) == "c3") { | ||
| self.incrementScore(5, player); | ||
| } |
There was a problem hiding this comment.
To clean up these else if statements, you could use JavaScript's switch statement. It's very similar to Ruby's case statement!
|
Your code was very clean and easy to follow, so there was not much for me to comment on! I liked your logic for gameplay. You'll find that there are a lot of similar functions in Javascript and Ruby, like the switch case statement, that you can use to clean up the code a bit. Really awesome job for your first Javascript project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed all project requirements and some optional requirements:
Additional work not yet completed: