Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project PR #13

Open
wants to merge 8 commits into
base: riley
Choose a base branch
from
Open

Project PR #13

wants to merge 8 commits into from

Conversation

rileslovesyall
Copy link

Game works.

Known bugs:
Squares can still be clicked even after the game has been won.

@EliaMG EliaMG self-assigned this Feb 9, 2016
<tr id="rowOne">
<td id="1"></td>
<td id="2"></td>
<td id="3"></td>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the indentation went a little wonky here-- good thing to watch for to improve code readability

@EliaMG
Copy link

EliaMG commented Feb 10, 2016

Nice dive into javascript! I'm sure you learned a lot more doing 2048, too 👍
I know you ran out of time to DRY up code, but it is great to think about different design approaches before starting to write code to prevent lots of conditional statements and case switching. 🎱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants