Audrey's tic-tac-toe #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,41 @@ | |||
| html { | |||
|
|
|||
| } | |||
There was a problem hiding this comment.
Make sure to remove these lines if not needed.
|
|
||
| //defines what the current board is | ||
| TicTacToe.prototype.updateBoard = function(nextBoard) { | ||
| this.currentBoard = nextBoard; | ||
| } |
There was a problem hiding this comment.
Nice job using SRP and making your functions do one specific thing.
|
Nice job! Your code was well formatted and easy to follow. Well done on commenting throughout your code and making the functions singly responsive (except that checkGame function). I like the theme you had going. Keep up the good work! 🌠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed rules and specs.
After a game is finished, clicking anyplace on the board starts a new game.
Chose to use 2D array for containing the board. To check for a win, board is broken down into the 8 possible winning combinations are forEach checked for equality.