Media Ranker Project #49
Conversation
| } | ||
|
|
||
| .page-header { | ||
| background: url(http://www.picgifs.com/glitter-gifs/h/hello-kitty/picgifs-hello-kitty-6615712.gif); |
There was a problem hiding this comment.
When using images it is safer to download the image and reference to it's folder location rather than rely on a 3rd party website. The image may get taken down or moved by the owner of the site or even worse could be swapped out for something unsavory.
| @@ -0,0 +1,63 @@ | |||
| class AlbumsController < ApplicationController | |||
|
|
|||
| def get_album | |||
There was a problem hiding this comment.
I love your get_album method! You could also set this as a private helper method that you call in a before acton at the top of your controller. Example: before_action :get_album, only: [:edit, :show, :update] The same can be done for your get_movie and get_book methods in their corresponding controllers.
|
|
Great job! You had an extensive set of tests and seem very comfortable with lets statements. Overall your code was clean and easy to read.
I've completed the project and everything looks great.
I'm planning to DRY using partials and rspec shared examples tomorrow, so I'll probably push again tomorrow!
Oh, and I used "hello kitty" image, since I can't see this owl staring at me. :-D