Final PR #48
Open
Final PR #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,57 @@ | |||
| class AlbumsController < ApplicationController | |||
| before_action :set_album, only: [:edit, :show, :update, :destroy, :upvote] | |||
There was a problem hiding this comment.
Nice use of a before_action. You could also do an except instead of only like so -> before_action :set_album , except: [:index, :create, :new]
|
Neat job. I'd add /coverage to your .gitignore so you're not uploading the huge files that get generated every time you run rspec and push. I like your use of shared examples, everything looked really consistent between the different medias. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a thing that looks like the other thing. It has some partials. That's cool.