Submitting MediaRanker #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd controller spec to begin drying up tests
…ation in the model
…changed some variable names throughout to make more clear
| def upvote | ||
| album = Album.find(params[:id]) | ||
| album.rank += 1 | ||
| album.save |
There was a problem hiding this comment.
👍 There's also a cool .increment! method that does the same thing as lines 9-10.
|
This looks awesome! 😄 It might be worth putting controller finds like Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting MediaRanker final project. Right now my controller tests are mostly testing that the pages are re-directing to the right place, but I was struggling with coming up with tests to make sure that the desired action of creating/deleting/editing was happening beforehand. I was not sure if this was needed, since this is provided by active record, but wanted to be sure that I was actually doing what was intended.