Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ricky final media ranker #27

Open
wants to merge 45 commits into
base: ricky/master
Choose a base branch
from

Conversation

hougland
Copy link

@hougland hougland commented Dec 4, 2015

all waves finished. look I'm filling in the message!

@Hamled Hamled self-assigned this Dec 7, 2015
end

def show
@media = Album.find(params[:id])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can DRY this out a bit by making this line into a before_action, because it is used to setup the @media variable the same way in multiple controller actions.

@Hamled
Copy link

Hamled commented Dec 7, 2015

Overall it looks great Ricky! Good use of many small commits with appropriate messages. I also like how DRY the test code is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants