Ashrlh/master #22
Open
Ashrlh/master #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls into ashrlh/master
…ls into ashrlh/master
…ils into ashrlh/master
| end | ||
|
|
||
| def mkt_home | ||
| @market = Market.find(params[:id]) |
There was a problem hiding this comment.
Because we're setting the @market variable in this same way in a few different methods, I think we could DRY this out a bit by moving that line into a before_action, like so:
class MarketsController < ApplicationController
before_action :find_market, only: [:mkt_home, :show, :edit, :update]
# all of your existing methods...
private
def find_market
@market = Market.find(params[:id])
end
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FarMarRails