FarMarRails #21
FarMarRails #21
Conversation
…for vendor class. Seed database
…to take in vendor_id params. Worksgit add .
…e individual vendor page
… an iterator that uses i
…sales data from vendor page
…for @if_market, @if_vendor, and @if_guest
| id = params[:id] | ||
| @market = Market.find(id) | ||
| @market = Market.find(params[:id]) | ||
| @is_market = true if session[:user_type] == "market" |
There was a problem hiding this comment.
By using the one-line conditionals here with the ifs, your code will attempt execution on each individual conditional. The problem with this is that each conditional is actually mutually exclusive, so if the first one is true, it should not continue attempting to execute the rest of the conditionals.
I think that an if/elsif/else condition would be better suited here.
|
Nice job on this! I like the way your final product turned out. Watch out for using the one-line conditionals if an if/elsif/else is more appropriate. It seemed like sometimes there was too much logic within the views and extra logic that wasn't being used (or I couldn't figure out where) in the controller. Potentially some additional separation of concerns would be in order here. @lacuchilla @CShekta |
FarMarRails project for Amy Hunter and Claire Schechter. URL is https://farmersmarketdata.herokuapp.com/