completed requirements plus some extras #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def update | ||
| id = params[:id] | ||
| @market = Market.find(id) |
There was a problem hiding this comment.
It would be great to see some refactoring of the id and @market variables to use a before_action
|
@jbuechs @kdefliese Nice job on this! I like some of the fanciness that you used in your design and the There are a few areas for improvement - but the primary one is to consider which method calls query the database and ensure that these are only being used when fully necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to our app: https://jbkd-farmar.herokuapp.com/
Some extras:
Used sessions to "log in" as market and vendor
Users can search for a market
Different navbars for different types of users
Form validation for required fields