Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water - Beatrice and Jessica #18

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

jwinchan
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C14/video-store-consumer-api#12
For each person in your pair, describe something you learned from your partner during this project Jessica: I learned how to pass down props to change the display button; Beatrice: I learned about React Router and how to combine Router and Bootstrap
What was one area of React you gained more clarity on during this assignment? Form handling in React; how to access an external API; and how to have a multipage application
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We render them on different pages with different route endpoints and different props so the accurate button (and corresponding function) renders.
Describe how you handled rentals with React We used State to keep track of the selected video and customer and then we created a checkout button to handle the POST API request.
Describe a DOM event your application handled When someone clicks 'Select Video' or 'Select Customer', it changes the state.
Did you use any functional stateless components? What for? Our Customer component is stateless because we only had to display the customer data. We didn't have to interact with it.
Did you use any container components? What for? CustomerCollection and VideoCollection were our container components. They compile their respective individual components into one long list.
Do you have any recommendations on how we could improve this project for the next cohort? There could be better documentation for the Rails API (ie the formatting for due date was ambiguous).

Beatress and others added 26 commits January 20, 2021 11:29
Rename errorMessage -> checkoutMessage, conditionally move checkout m…
Added PropTypes, removed unneeded comments, fixed ESlint warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants