Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth - Alice B. #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Earth - Alice B. #21

wants to merge 3 commits into from

Conversation

aliceboone
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Alice, well done. You hit the learning goals here. I had some comments on time/space complexity. However this is well done.

Comment on lines +19 to 21
# Time Complexity: O(log n)
# Space Complexity: O(1)
def add(key, value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The time complexity is O(log n) if the tree is balanced and O(n) if it's unbalanced.

The space complexity is the same (because of the recursion).

Comment on lines +40 to 42
# Time Complexity: O(log n)
# Space Complexity: O(log n)
def find(key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The time complexity is O(log n) if the tree is balanced and O(n) if it's unbalanced.

The space complexity is the same (because of the recursion).

Comment on lines +74 to 76
# Time Complexity: O(n)
# Space Complexity: O(n)
def preorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +90 to 92
# Time Complexity: O(n)
# Space Complexity: O(n)
def postorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +106 to 108
# Time Complexity: O(n)
# Space Complexity: O(n)
def height

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The space complexity (due to recursion) is O(log n) if the tree is balanced and O(n) if it's unbalanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants