Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Carla & Pauline #30

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

Conversation

paulentine
Copy link

@paulentine paulentine commented Jun 28, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#15
For each person in your pair, describe something you learned from your partner during this project Carla: I learned a lot from Pauline's workflow and thoroughness. She is very organized and her code style shows it. Pauline: Carla did the research on React routing explained it really well. Carla is absolutely brilliant and a delight to work with!
What was one area of React you gained more clarity on during this assignment? Carla: React routing. Pauline: Apparently, housing nearly all states in one parent component is a common pattern in React. It felt counter-intuitive to the notion of React components' modularity at first, but allows benefits such as polymorphism.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We used a single Movie component to render movies from search and movies already in library by passing in different functions. Movie does not need to know where it is inheriting from, just how to render what it has.
Describe how you handled rentals with React We added a create action, utilizing MovieWrapper's built in function so we only need to pass in the movie's title.
Describe a DOM event your application handled When there is a movie and a customer selected, the check out button is no longer disabled, and allows user to check out.
Did you use any functional stateless components? What for? All of our components are stateless, except for VideoStore, where we keep all our states.
Did you use any container components? What for? VideoStore, to handle routing.
Do you have any recommendations on how we could improve this project for the next cohort? None, it was great!

paulentine and others added 30 commits June 24, 2019 12:23
Retrieve and display list of movies
Lift Movies & SearchBar states to VideoStore
…, rendered by SearchMatches component. Adding to movieList is WIP.
…rns new movie's ID, updates & rerenders movieList
SearchBar queries external API, returns searchMatches (kept in state)…
`Components` folder name capitalization issue
carlabosco and others added 30 commits June 27, 2019 14:33
Refactor & add user reporting
Add favicon, title font, and customers table
Better handling of newly created object, display movies as cards
Add space between cards, change font-size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants