Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Hana && Sarah #21

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Sockets - Hana && Sarah #21

wants to merge 70 commits into from

Conversation

hanalways
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Video Store Consumer API
For each person in your pair, describe something you learned from your partner during this project Sarah - Hana figured out how to use the React Router and showed me how to use it. Hana - Sarah did a fantastic job implementing the popup library and I got to see how they can be used!
What was one area of React you gained more clarity on during this assignment? Designing the front end so that components can be reused, specifically using the Movie component for two different types of movies (library and search).
Describe how you solved the problem of having lists of movies that look mostly the same but have different content Each list was a separate component (library and search) but they both rendered the movie component in the same way, and shared the same generateMovie component function. We wrote a conditional to display different buttons dependent on if they were generated from library or search.
Describe how you handled rentals with React A user can select a movie from the library and a customer from the customerlist which are both saved as state in that router. These will be passed in as props to the selectBar component. Once a user is satisfied with the selections, they can click on the Checkout Rental button which makes a post request to rentals and stores it in our API.
Describe a DOM event your application handled When a user clicks Checkout Rental from the selections provided, if the requirements are met then the ErrorMessage component will render a success message if the post was successful, an error message if it was not.
Did you use any functional stateless components? What for? ErrorMessage, SelectBar, Movie, MoviePopup were all functional stateless components because they didn't hold any state and instead relied on the props that were being passed in. Customer should have been stateless but we're really lazy.
Did you use any container components? What for? Library, Search, App were all container components as they referenced and stored information in their state.
Do you have any recommendations on how we could improve this project for the next cohort? Not doing presentations because they are all such similar projects. It might be a good idea to have laptops set up with their local version and do more of a walk around tour where people can mingle and talk about their code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants