Ports - Amy W

[amythetester]

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	It was very hard to decide which of the many designs I started with to work on. It has also been a challenge to figure out which classes should own each method.
What was a design decision you made that changed over time over the project?	I ended up adding more methods and variables to the hotel and reservation class.
What was a concept you gained clarity on, or a learning that you'd like to share?	attr_readers and instance variables...and how they help with scope in their own right. TDD became much easier on this project.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	Testing that add reservation adds the selected reservation to @Reservations. This is a nominal case because we would expect add reservation to add a reservation to the list.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	Testing the list reservations when no reservations have been made. This is an edge case because you would expect a hotel to have reservations.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	It was hard to write pseudocode when the concept I was going for was straightforward. Otherwise, this practice helps setup your tests while also allowing them to fail for the Red/Green process.

[CheezItMan]

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Not many commits, but good commit messages
Answer comprehension questions	Check, btw I love your github name! I understand pseudocode can be hard to get started with, I hope it helped with your TDD.
Design
Each class is responsible for a single piece of the program	Check
Classes are loosely coupled	Check
Wave 1
List rooms
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check
Invalid date range produces an error	Check
Test coverage	43.24%
Wave 2	INCOMPLETE
View available rooms for a given date range
Reserving a room that is not available produces an error
Test coverage
Wave 3	INCOMPLETE
Create a block of rooms
Check if a block has rooms
Reserve a room from a block
Test coverage
Fundamentals
Names variables, classes and modules appropriately	Check
Understanding of variable scope - local vs instance	Check
Can create complex logical structures utilizing variables	From what I can see thus far, yes
Appropriately uses methods to break down tasks into smaller simpler tasks	Check
Understands the differences between class and instance methods	Check
Appropriately uses iterators and Enumerable methods	Not observed at this point in the project.
Appropriately writes and utilizes classes	Check
Appropriately utilizes modules as a namespace	NOPE
Wrap Up
There is a refactors.txt file	MISSING
The file provides a roadmap to future changes	MISSING
Additional Feedback	With your trip you definitely couldn't get the project done. What you did have works and I look forward to seeing what you get working for Hotel revisted. You didn't have time to get to all our learning goals, hopefully you can get more accomplished in the next few projects.

[CheezItMan]

I would make this if date >= reservation.start_date && date < reservation.end_date, just because someone can reserve a room on a date that another reservation ends.