Sockets - Riyo #24

RPerry · 2019-03-18T06:40:15Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	Figuring out how the checkin and checkout times needed to be manipulated and what I would need the DateRange class to do.
What was a design decision you made that changed over time over the project?	Instead of having the reservation booker class maintain most of the methods, I moved the methods to other classes and had reservation call those methods when necessary
What was a concept you gained clarity on, or a learning that you'd like to share?	Nothing, I felt like I was regressing in my knowledge of ruby concepts, if anything.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	When validating checkin and checkout dates, I wrote a test that had the checkin date further in the future than the checkout date. It is a nominal case because it is obvious what the program will do when encountering it.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	Will have to add edge cases.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	When writing pseudocode, my reasoning behind designing my code the way I did made more sense than in reality when I was actually writing the tests and code.

I still have a failing test and only got through Wave 2

dHelmgren · 2019-03-30T00:42:21Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	I expect to see more check ins for a project of this size.
Answer comprehension questions	I'm sorry that you felt like your were slipping in your understanding of Ruby during this project.
Design
Each class is responsible for a single piece of the program	Yes, but it might be overdivided, see comments
Classes are loosely coupled	Less so. You've created coupling between Rooms and Reservations.
Wave 1
List rooms	Yes
Reserve a room for a given date range	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	Pretty good
Wave 2
View available rooms for a given date range	Yes
Reserving a room that is not available produces an error	yes
Test coverage	Missed some edge cases that are important, see comments. Also, you've got a broken test!
Wave 3	DNF
Create a block of rooms
Check if a block has rooms
Reserve a room from a block
Test coverage
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes, but see comments. You've written methods for things Ruby can already do.
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	You're getting there, see comments
Appropriately utilizes modules as a namespace	Yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes
Additional Feedback	It seems like you took a hit to your confidence on this one. I think this submission is pretty solid, but I agree with at least one of your assessments: you should be writing more edge case tests. You are very thorough in the way you write your code, but you could also stand to do a little more research before jumping into an implementation. You should be proud of what you did here! I hope you take some time to talk to Dan or Kaida about how this project went for you when you get back from the break.

dHelmgren · 2019-03-30T00:15:37Z

spec/reservation_booker_spec.rb

+
+    it "raises an argument error if attempting to reserve an unavailable room" do
+        @reservation_booker.create_new_reservation(2019, 02, 10, 2019, 02, 12)
+        expect {@reservation_booker.create_new_reservation(2019, 02, 10, 2019, 02, 12)}.must_raise ArgumentError


This test had an error when I ran it.

dHelmgren · 2019-03-30T00:19:19Z

lib/all_rooms.rb

@@ -0,0 +1,38 @@
+module Hotel
+    class AllRooms


This is a small thing to prepare for Rails, but we generally don't name a class in the plural. Since classes are meant to be instantiated, we name them in the singular, as they represent the 'bones' of one entity.

dHelmgren · 2019-03-30T00:26:35Z

lib/date_range.rb

+
+module Hotel
+    class DateRange
+      def self.valid_checkin_dates?(check_in_year, check_in_month, check_in_day)


For the whole of the DateRange class, it would have been okay to pass in a Date object instead of passing in the day, month and year. You can rely on Date to make sure that the date is properly formatted.

dHelmgren · 2019-03-30T00:27:04Z

lib/date_range.rb

+        return is_valid
+        end
+
+        def self.valid_checkout_dates?(check_out_year, check_out_month, check_out_day)


This does the same as the code above, so I'm not sure it's needed.

dHelmgren · 2019-03-30T00:28:01Z

lib/room.rb

+
+
+
+    def available_on_these_dates?(check_in_date, check_out_date)


Nice! This is a good way to solve this problem.

dHelmgren · 2019-03-30T00:30:53Z

lib/reservation_booker.rb

+    attr_reader :all_reservations
+
+    def initialize
+      @all_rooms = Hotel::AllRooms.new


It would have been OK to let ReservationBooker and AllRooms be the same class. The booker would have been responsible for managing the rooms and the reservations, which would create coupling, but to an acceptable degree.

dHelmgren · 2019-03-30T00:31:43Z

lib/date_range.rb

+            return is_valid
+        end
+
+        def self.check_in_date(check_in_year, check_in_month, check_in_day)


Again, let the date class do this work for you. All you've done here is make a small wrapper.

dHelmgren · 2019-03-30T00:37:26Z

lib/reservation_booker.rb

+      rooms_not_reserved = available_rooms_by_date_range(check_in_year, check_in_month, check_in_day, check_out_year, check_out_month, check_out_day)
+      room = rooms_not_reserved.sample
+
+      if room.available_on_these_dates?(check_in_date, check_out_date) == false


This check should be taken care of if available_rooms_by_date_range can be trusted. But a good check to put here: what if there are no rooms left?

RPerry added 5 commits March 11, 2019 13:54

created reservationbooker class

c1b190b

most of wave 1

d8334f6

fixed add_reservation test for Room

b276e15

argument error for unavailable room not fixed

047751d

added refactor file

244f2cd

dHelmgren reviewed Mar 30, 2019

View reviewed changes

RPerry added 2 commits April 2, 2019 06:35

"added design activity"

10c6070

added design activity

7b23cbd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sockets - Riyo #24

Sockets - Riyo #24

RPerry commented Mar 18, 2019

dHelmgren commented Mar 30, 2019

dHelmgren Mar 30, 2019

dHelmgren Mar 30, 2019

dHelmgren Mar 30, 2019

dHelmgren Mar 30, 2019

dHelmgren Mar 30, 2019

dHelmgren Mar 30, 2019

dHelmgren Mar 30, 2019

dHelmgren Mar 30, 2019




		def available_on_these_dates?(check_in_date, check_out_date)

Sockets - Riyo #24

Are you sure you want to change the base?

Sockets - Riyo #24

Conversation

RPerry commented Mar 18, 2019

Hotel

Comprehension Questions

dHelmgren commented Mar 30, 2019

Hotel

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment